Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(checkbox): match styles to checkbox icon #13386

Merged

Conversation

alisonjoseph
Copy link
Member

@alisonjoseph alisonjoseph commented Mar 21, 2023

Closes #10668

Icon
Screenshot 2023-03-21 at 1 10 42 PM

After vs. Before
Screenshot 2023-03-21 at 1 07 15 PM

Changelog

Changed

  • update checkbox styles to more closely match icon
    • increase border radius
    • decrease width of check
    • center checkmark visually

Testing / Reviewing

Visually check that updated styles for checkbox look ok
https://deploy-preview-13386--carbon-components-react.netlify.app/?path=/story/components-checkbox--default

@netlify
Copy link

netlify bot commented Mar 21, 2023

Deploy Preview for carbon-components-react ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 4452dd8
🔍 Latest deploy log https://app.netlify.com/sites/carbon-components-react/deploys/641c922c5061b9000825d9bc
😎 Deploy Preview https://deploy-preview-13386--carbon-components-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Mar 21, 2023

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 4452dd8
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/641c922c078b7a0008b65d52
😎 Deploy Preview https://deploy-preview-13386--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid to me! 👍

Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@francinelucca francinelucca removed their request for review March 22, 2023 16:19
@kodiakhq kodiakhq bot merged commit e985d76 into carbon-design-system:main Mar 23, 2023
tw15egan pushed a commit to tw15egan/carbon that referenced this pull request Mar 31, 2023
)

Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Inconsistent Checkbox
4 participants