feat(React): update more components to use Text, improve RTL support #14679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tw15egan
force-pushed
the
add-text-to-more-components
branch
from
0d22f3e
to
048742e
Compare
…bon into add-text-to-more-components
tw15egan
commented
Sep 22, 2023
| @@ -9,7 +9,7 @@ import PropTypes from 'prop-types'; | |||
| import React, { ReactNode, useEffect, useMemo, useRef } from 'react'; | |||
| import { TextDirectionContext } from './TextDirectionContext'; | |||
|
|
|||
| export type TextDir = 'ltr' | 'rtl' | 'auto'; | |||
| export type TextDir = 'ltr' | 'rtl' | 'auto' | string; | |||
There was a problem hiding this comment.
Needed to add string because some components that were changed to Text were spreading ...other. This was causing TypeScript errors because the types for dir are string | undefined on ComponentProps (ListItem was throwing this)
tay1orjones
reviewed
Sep 27, 2023
tay1orjones
approved these changes
Oct 2, 2023
Merged
via the queue into
carbon-design-system:main
with commit Oct 18, 2023
5d00063
17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #14477
Refs #7264
Adds in more support for RTL mode by utilizing the
Textcomponent under the hood wherever we render visible text. Also sets theTextDirectionat the root level of the story.Changelog
New
TextDirectionat the root level based on theText Directiondropdown in storybookChanged
TextcomponentTesting / Reviewing
Ensure there are no regressions when viewing the components in RTL or LTR mode