feat(Tile): update Tile AI styles to phase 2 spec #15596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
aagonzales
reviewed
Jan 25, 2024
There was a problem hiding this comment.
When checking for the hover state, I realized my selected state designs have been inconsistent with the new carbon tile designs. It should not have a background change, only a border change.
Here is the new spec for selected and selected-hover
tw15egan
force-pushed
the
phase2-tile-updates
branch
from
a172159 to
a11cd20
Compare
tay1orjones
approved these changes
Jan 26, 2024
aagonzales
approved these changes
Jan 26, 2024
Merged
via the queue into
carbon-design-system:main
with commit Jan 26, 2024
8114072
20 checks passed
This was referenced Jan 29, 2024
kodiakhq bot
pushed a commit
to carbon-design-system/carbon-for-ibm-dotcom
that referenced
this pull request
Feb 2, 2024
### Related Ticket(s) Follows: carbon-design-system/carbon#15596 & carbon-design-system/carbon#15591 ### Description Updates Tile with carbon gradient ### Changelog **Changed** - new carbon upgrade (using RC atm -> will need to update to full release) - updated tile slug styles like core - the new core styles fix an error with number-input slug revert styles <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
kennylam
pushed a commit
to kennylam/carbon-for-ibm-dotcom
that referenced
this pull request
Jun 11, 2024
### Related Ticket(s) Follows: carbon-design-system/carbon#15596 & carbon-design-system/carbon#15591 ### Description Updates Tile with carbon gradient ### Changelog **Changed** - new carbon upgrade (using RC atm -> will need to update to full release) - updated tile slug styles like core - the new core styles fix an error with number-input slug revert styles <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
kennylam
pushed a commit
to kennylam/carbon
that referenced
this pull request
Jul 30, 2024
### Related Ticket(s) Follows: carbon-design-system#15596 & carbon-design-system#15591 ### Description Updates Tile with carbon gradient ### Changelog **Changed** - new carbon upgrade (using RC atm -> will need to update to full release) - updated tile slug styles like core - the new core styles fix an error with number-input slug revert styles <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15595
Updates
Tileto new phase 2 AI specChangelog
New
ClickableTileandSelectableTilehover statescallout-gradientmixin that takes in a background. Right now, only configured to handlelayer(Tile) and defaults tobackground(Callout)box-shadowadded toTileChanged
border-radiusfrom16pxto8pxon theTilewith rounded cornersRemoved
Testing / Reviewing
Go to
unstable__Slug --> Examples --> Tileand ensure all states match the spec.Questions
@aagonzales is there a state for selected + hover?