-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: focus issue in menu #17047
fix: focus issue in menu #17047
Conversation
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is such an excellent improvement! Just a couple things I noticed
handleClose: safePolygon({ | ||
requireIntent: true, | ||
}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here I'm trying to get to Italic
, but can't get there even though I'm in the triangle. The Share with
item is being invoked when I expect it to be ignored. Maybe the blockPointerEvents
option could help?
2024-07-29.at.11.06.45-MAIN-Google.Chrome-converted.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blockPointerEvents was blocking the entire menu from any event. its happening only when any other pointer comes under the safePolygon. If you try it withShare with
It works fine. So I added a delay
of 100ms to avoid the issue.
0c456e9
Closes #16994
Fix the inconsistency in menu where it has more than 2 menu items with submenus.
Changed
The issue was causing because of delay in closing the submenu.
Added floating ui - safePolygon so menu will not close when user hover on submenu.
Added floating ui - FloatingFocusManager to manage the focus.