Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codesnippet): inline button should be width of content #17301

Merged

Conversation

tay1orjones
Copy link
Member

@tay1orjones tay1orjones commented Aug 29, 2024

Reported in slack, the inline code snippet button was incorrectly limited to 320px wide causing a display issue:

image

Changelog

Changed

  • Update code snippet styles to unset the max-inline-width

Removed

  • Remove the declaration-property-value-disallowed-list rule that disallowed unset due to lack of support in IE11. IE11 isn't in our support matrix anymore, so I think this can be safely removed from the config

Testing / Reviewing

  • Go the code snippet inline story, edit the text to be a really long string. It should display properly.
2024-08-29.at.13.59.52-MAIN-Google.Chrome.mp4

@tay1orjones tay1orjones requested a review from a team as a code owner August 29, 2024 19:00
@tay1orjones tay1orjones self-assigned this Aug 29, 2024
Copy link

netlify bot commented Aug 29, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 7455aee
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/66d0c56095ad960008ea35a5
😎 Deploy Preview https://deploy-preview-17301--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 29, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 7455aee
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/66d0c5604d9bd200081d6903
😎 Deploy Preview https://deploy-preview-17301--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so fast! LGTM

@guidari guidari added this pull request to the merge queue Aug 30, 2024
Merged via the queue into carbon-design-system:main with commit e063a4c Aug 30, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants