-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ComboBox readonly state fixed #17457
fix: ComboBox readonly state fixed #17457
Conversation
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17457 +/- ##
==========================================
- Coverage 77.03% 77.02% -0.01%
==========================================
Files 408 408
Lines 13994 14001 +7
Branches 4352 4353 +1
==========================================
+ Hits 10780 10784 +4
- Misses 3041 3044 +3
Partials 173 173 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good Guru! 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Gururaj, The readonly prop is working fine now. Only one thing I noticed in deploy preview is when we press Tab Key, The focus move to other elements which is fine but combobox is still in highlight state, which I believe should not be. Please check attached screen recording.
After that I am not able to remove highlight from combobox even by clicking outside as well.
Screen.Recording.2024-09-19.at.10.41.37.AM.mov
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working fine now 👍
2d0b6a4
Closes #17382
Fixed the Combobox's Read Only state, which previously would allow the user to interact with the list box.
This modification has been done after referring the read only states of Dropdown and Multiselect.
Dropdown's readonly story for reference:
https://react.carbondesignsystem.com/?path=/story/components-dropdown--playground&args=readOnly:!true
Changelog
New
event.preventDefault();
for Tab interaction for readOnly propTesting / Reviewing