-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Dropdown): make titleText required #17886
fix(Dropdown): make titleText required #17886
Conversation
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17886 +/- ##
=======================================
Coverage 80.35% 80.35%
=======================================
Files 406 406
Lines 14041 14041
Branches 4395 4395
=======================================
Hits 11282 11282
+ Misses 2593 2592 -1
- Partials 166 167 +1 ☔ View full report in Codecov by Sentry. |
5e87fc9
Closes #16602
related #12809
This PR makes the
titleText
prop required for the dropdown component again to resolve console errors when the prop is undefinedChangelog
Changed
titleText
required in dropdown component aganiTesting / Reviewing
confirm no prop type errors are logged when
titleText
is missing or undefined in dropdown components