Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dropdown): make titleText required #17886

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Oct 25, 2024

Closes #16602
related #12809

This PR makes the titleText prop required for the dropdown component again to resolve console errors when the prop is undefined

Changelog

Changed

  • titleText required in dropdown component agani

Testing / Reviewing

confirm no prop type errors are logged when titleText is missing or undefined in dropdown components

@emyarod emyarod requested a review from a team as a code owner October 25, 2024 16:49
Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 871dc65
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/671bcc2439e02900087a37ed
😎 Deploy Preview https://deploy-preview-17886--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 871dc65
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/671bcc242a43d900089c068e
😎 Deploy Preview https://deploy-preview-17886--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Oct 25, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 871dc65
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/671bcc24b38dbb0008c261a6
😎 Deploy Preview https://deploy-preview-17886--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.35%. Comparing base (114c71e) to head (871dc65).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17886   +/-   ##
=======================================
  Coverage   80.35%   80.35%           
=======================================
  Files         406      406           
  Lines       14041    14041           
  Branches     4395     4395           
=======================================
  Hits        11282    11282           
+ Misses       2593     2592    -1     
- Partials      166      167    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@annawen1 annawen1 added this pull request to the merge queue Oct 25, 2024
Merged via the queue into carbon-design-system:main with commit 5e87fc9 Oct 25, 2024
27 checks passed
@emyarod emyarod deleted the 16602-fix/dropdown-titleText-require branch November 13, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Dropdown's titleText prop is incorrectly marked as not required
3 participants