Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(subgrid): narrow mode margin #18255

Merged

Conversation

alisonjoseph
Copy link
Member

@alisonjoseph alisonjoseph commented Dec 16, 2024

Closes #18111

Changelog

Changed

  • Added examples to subgrid story
  • Update --cds-grid-gutter-start from 0 to 0rem to ensure calc values are rendered correctly

Removed

Testing / Reviewing

  • check subgrid story and ensure margins are rendering correctly

Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 9bb3b03
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/676078d374d02500082fd276
😎 Deploy Preview https://deploy-preview-18255--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 9bb3b03
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/676078d3736b1f000877e68c
😎 Deploy Preview https://deploy-preview-18255--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 9bb3b03
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/676078d356488a00084af2ec
😎 Deploy Preview https://deploy-preview-18255--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 90f7222
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67607a0300ac5200083f7473
😎 Deploy Preview https://deploy-preview-18255--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 90f7222
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/67607a0382b70d00080bdc65
😎 Deploy Preview https://deploy-preview-18255--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 90f7222
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/67607a03981c4a00085707ae
😎 Deploy Preview https://deploy-preview-18255--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 0a55588
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/67607acb78fec300086ee817
😎 Deploy Preview https://deploy-preview-18255--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alisonjoseph alisonjoseph marked this pull request as ready for review December 16, 2024 19:18
@alisonjoseph alisonjoseph requested a review from a team as a code owner December 16, 2024 19:18
Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for carbon-elements ready!

Name Link
🔨 Latest commit 7877fe7
🔍 Latest deploy log https://app.netlify.com/sites/carbon-elements/deploys/6760abd28595d80008b39ebc
😎 Deploy Preview https://deploy-preview-18255--carbon-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit 7877fe7
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/6760abd2aa3f950008cf6a51
😎 Deploy Preview https://deploy-preview-18255--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 16, 2024

Deploy Preview for v11-carbon-web-components ready!

Name Link
🔨 Latest commit 7877fe7
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-web-components/deploys/6760abd23d05cd0008cae563
😎 Deploy Preview https://deploy-preview-18255--v11-carbon-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.31%. Comparing base (2c2bbcb) to head (7877fe7).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #18255   +/-   ##
=======================================
  Coverage   84.31%   84.31%           
=======================================
  Files         404      404           
  Lines       14353    14353           
  Branches     4655     4655           
=======================================
  Hits        12102    12102           
  Misses       2089     2089           
  Partials      162      162           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alisonjoseph alisonjoseph changed the title fix(subgrid): narrow mode margin value fix(subgrid): narrow mode margin Dec 16, 2024
@tay1orjones tay1orjones added this pull request to the merge queue Dec 17, 2024
Merged via the queue into carbon-design-system:main with commit d56c885 Dec 17, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Columns in subgrid in narrow grid are not aligning properly
3 participants