Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notification): fix low contrast markup #3899

Conversation

asudoh
Copy link
Contributor

@asudoh asudoh commented Sep 4, 2019

Refs #2927.

Changelog

Changed

  • Fix duplicate Fractal variant ID for inline notification markups.

Testing / Reviewing

Testing should make sure the vanilla dev env for notification is not broken.

@netlify
Copy link

netlify bot commented Sep 4, 2019

Deploy preview for the-carbon-components ready!

Built with commit 8ad1693

https://deploy-preview-3899--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Sep 4, 2019

Deploy preview for carbon-elements ready!

Built with commit 8ad1693

https://deploy-preview-3899--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Sep 4, 2019

Deploy preview for carbon-components-react ready!

Built with commit 8ad1693

https://deploy-preview-3899--carbon-components-react.netlify.com

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, inline low contrast notification now displaying correctly

image

@tw15egan tw15egan merged commit 95e02b9 into carbon-design-system:master Sep 4, 2019
@asudoh asudoh deleted the fix-low-contrast-notification-markup branch September 4, 2019 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants