fix(skeleton): disable motion if prefers-reduced-motion is true #3905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
|
Deploy preview for the-carbon-components ready! Built with commit 310bd40 https://deploy-preview-3905--the-carbon-components.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 310bd40 |
|
Deploy preview for carbon-components-react ready! Built with commit 310bd40 https://deploy-preview-3905--carbon-components-react.netlify.com |
|
Deploy preview for the-carbon-components ready! Built with commit fec4d9c https://deploy-preview-3905--the-carbon-components.netlify.com |
shixiedesign
approved these changes
Sep 4, 2019
|
Deploy preview for carbon-components-react ready! Built with commit fec4d9c https://deploy-preview-3905--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit fec4d9c |
joshblack
approved these changes
Sep 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #2440
Refs #3897
Improvement that can immediately target
skeletoncomponents. Having this disable animations throughout the library will be a larger undertakingChangelog
New
prefers-reduced-motionis set to trueTesting / Reviewing
To enable
prefers-reduced-motion, follow these steps then refresh theskeletonpage: