Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(codeowners): add default pr reviewers #3929

Merged
merged 3 commits into from
Sep 6, 2019
Merged

chore(codeowners): add default pr reviewers #3929

merged 3 commits into from
Sep 6, 2019

Conversation

jnm2377
Copy link
Contributor

@jnm2377 jnm2377 commented Sep 6, 2019

Adds dev and design teams as default codeowners for pull panda to automatically assign people.

@jnm2377 jnm2377 requested review from joshblack and a team September 6, 2019 16:02
@ghost ghost requested review from vpicone and removed request for a team September 6, 2019 16:02
Copy link
Contributor

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want design on every PR? Might get noisy for them (I think this is 100% needed for website though 👍)

@netlify
Copy link

netlify bot commented Sep 6, 2019

Deploy preview for the-carbon-components ready!

Built with commit b211681

https://deploy-preview-3929--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Sep 6, 2019

Deploy preview for carbon-components-react ready!

Built with commit b211681

https://deploy-preview-3929--carbon-components-react.netlify.com

@netlify
Copy link

netlify bot commented Sep 6, 2019

Deploy preview for carbon-elements ready!

Built with commit b211681

https://deploy-preview-3929--carbon-elements.netlify.com

@jnm2377
Copy link
Contributor Author

jnm2377 commented Sep 6, 2019

@joshblack wasn't sure how we wanted it to be. can definitely update it to be just devs.

Copy link
Collaborator

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jnm2377 jnm2377 merged commit 7124b86 into carbon-design-system:master Sep 6, 2019
@jnm2377 jnm2377 deleted the add-codeowners branch September 6, 2019 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants