Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(github): add github action for deploying storybook #3950

Conversation

joshblack
Copy link
Contributor

Updates our CI workflow for publishing storybook from CircleCI to GitHub Actions.

cc @alisonjoseph for help with syntax lol 😂

Changelog

New

  • New GitHub Action for deploying our React storybook on a tag push that matches v*.*.*

Changed

  • CircleCI no longer publishes on tags

Removed

Testing / Reviewing

Honestly not sure, I think we'll have to wait till our next patch release when we push the tag! 😬

@netlify
Copy link

netlify bot commented Sep 10, 2019

Deploy preview for the-carbon-components ready!

Built with commit 0dc74af

https://deploy-preview-3950--the-carbon-components.netlify.com

@netlify
Copy link

netlify bot commented Sep 10, 2019

Deploy preview for carbon-components-react ready!

Built with commit 0dc74af

https://deploy-preview-3950--carbon-components-react.netlify.com

@joshblack joshblack marked this pull request as ready for review September 10, 2019 23:05
@joshblack joshblack requested a review from a team September 10, 2019 23:05
@ghost ghost requested review from abbeyhrt and emyarod and removed request for a team September 10, 2019 23:05
@joshblack
Copy link
Contributor Author

@jnm2377 do you happen to know why this path wasn't picked up by CODEOWNERS?

@netlify
Copy link

netlify bot commented Sep 10, 2019

Deploy preview for carbon-elements ready!

Built with commit 0dc74af

https://deploy-preview-3950--carbon-elements.netlify.com

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build/login/deploy stuff all looks good to me!

@joshblack joshblack merged commit 11a8dab into carbon-design-system:master Sep 10, 2019
@joshblack joshblack deleted the ci/add-storybook-deploy-workflow branch September 10, 2019 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants