-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(text-area): change disabled light textarea background colors #4983
fix(text-area): change disabled light textarea background colors #4983
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 - Thanks @tw15egan!
Deploy preview for the-carbon-components ready! Built with commit 02b4a88 https://deploy-preview-4983--the-carbon-components.netlify.com |
Deploy preview for carbon-components-react ready! Built with commit 02b4a88 https://deploy-preview-4983--carbon-components-react.netlify.com |
Deploy preview for carbon-elements failed. Built with commit 02b4a88 https://app.netlify.com/sites/carbon-elements/deploys/5e165f9db3e5f1000a45dc93 |
Deploy preview for the-carbon-components ready! Built with commit e4517ed https://deploy-preview-4983--the-carbon-components.netlify.com |
Deploy preview for carbon-elements failed. Built with commit 2682088 https://app.netlify.com/sites/carbon-elements/deploys/5e1753c6ebb2f60008c0c57d |
Deploy preview for carbon-components-react ready! Built with commit b8adc31 https://deploy-preview-4983--carbon-components-react.netlify.com |
Deploy preview for the-carbon-components ready! Built with commit b8adc31 https://deploy-preview-4983--the-carbon-components.netlify.com |
Deploy preview for the-carbon-components ready! Built with commit 2682088 https://deploy-preview-4983--the-carbon-components.netlify.com |
Deploy preview for carbon-components-react failed. Built with commit 2682088 https://app.netlify.com/sites/carbon-components-react/deploys/5e1753c64b02060008198476 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Closes #4964
We don't want the field background changing when a textarea is disabled. I was also investigating why placeholder colors are not correct, but I wasn't able to modify any of them unless I used an
!important
...