fix(pagination): use descriptive id for right hand select #5109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
joshblack
approved these changes
Jan 20, 2020
|
Deploy preview for the-carbon-components ready! Built with commit 3236b23 https://deploy-preview-5109--the-carbon-components.netlify.com |
|
Deploy preview for carbon-components-react ready! Built with commit 3236b23 https://deploy-preview-5109--carbon-components-react.netlify.com |
|
Deploy preview for carbon-elements ready! Built with commit 3236b23 |
dakahn
approved these changes
Jan 20, 2020
asudoh
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4656
Multiple pagination components on the same page caused DAP errors due to duplicate ID's
Changelog
Changed
rightinstead of an incrementedidwhich caused collisions when there were multiple pagination componentsTesting / Reviewing
Open the multiple pagination component examples and ensure there are no more DAP errors.