Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also add ref to non-sortable branch in TableHeader #5204

Merged
merged 9 commits into from
Jan 30, 2020
Merged

Also add ref to non-sortable branch in TableHeader #5204

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
dc555cd
Merge pull request #1 from carbon-design-system/master
gmoehler Sep 3, 2019
5c7c833
Merge pull request #2 from carbon-design-system/master
gmoehler Sep 4, 2019
8a65776
Merge pull request #3 from carbon-design-system/master
gmoehler Sep 11, 2019
cf2fb8d
Merge branch 'master' of github.com:carbon-design-system/carbon
Jan 28, 2020
39370d6
Merge branch 'master' of github.com:carbon-design-system/carbon
Jan 29, 2020
0b40e75
fix: also add ref to non sortable branch
Jan 29, 2020
675c1c6
Update packages/react/src/components/DataTable/TableHeader.js
gmoehler Jan 30, 2020
ecc08a9
Merge branch 'master' into add-ref-to-nonsortable
gmoehler Jan 30, 2020
4c22775
fix: reformat file
Jan 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/react/src/components/DataTable/TableHeader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,12 @@ const TableHeader = React.forwardRef(function TableHeader(
) {
if (!isSortable) {
return (
<th {...rest} className={headerClassName} scope={scope} colSpan={colSpan}>
<th
{...rest}
className={headerClassName}
scope={scope}
colSpan={colSpan}
ref={ref}>
<span className={`${prefix}--table-header-label`}>{children}</span>
</th>
);
Expand Down