-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(react): update wildcard exports #5220
refactor(react): update wildcard exports #5220
Conversation
Deploy preview for the-carbon-components ready! Built with commit 98d3797 https://deploy-preview-5220--the-carbon-components.netlify.com |
Deploy preview for carbon-components-react ready! Built with commit 98d3797 https://deploy-preview-5220--carbon-components-react.netlify.com |
Deploy preview for carbon-elements ready! Built with commit 98d3797 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wooo! Storybook deploys are back 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 ✅
Updates how we use
export ns from
to fix our deployed storybook in production. While debugging, I discovered that the ordering of the import/export matter. Specifically:Updating this order to the following would address this issue:
I'm still unsure as to why but figured we could address the issue first and then figure out what's going on.
Changelog
New
Changed
export ns from
statements to top of import blockRemoved