Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(notification): inline notification fits parent container #5268

Merged
merged 3 commits into from
Feb 5, 2020
Merged

fix(notification): inline notification fits parent container #5268

merged 3 commits into from
Feb 5, 2020

Conversation

tw15egan
Copy link
Collaborator

@tw15egan tw15egan commented Feb 4, 2020

Closes #4554

Sets width: 100% so that InlineNotification fills its parent container, up to it's max-width

Changelog

New

  • width: 100% on InlineNotification

@tw15egan tw15egan requested a review from a team as a code owner February 4, 2020 22:26
@ghost ghost requested review from abbeyhrt and aledavila February 4, 2020 22:26
@tw15egan tw15egan requested review from a team and laurenmrice and removed request for a team February 4, 2020 22:26
@netlify
Copy link

netlify bot commented Feb 4, 2020

Deploy preview for carbon-elements ready!

Built with commit 0d30b49

https://deploy-preview-5268--carbon-elements.netlify.com

@netlify
Copy link

netlify bot commented Feb 4, 2020

Deploy preview for carbon-components-react failed.

Built with commit 0d30b49

https://app.netlify.com/sites/carbon-components-react/deploys/5e39ef9152787f000ac11a9d

@netlify
Copy link

netlify bot commented Feb 4, 2020 •
edited
Loading

Deploy preview for carbon-elements failed.

Built with commit 9f830b5

https://app.netlify.com/sites/carbon-elements/deploys/5e3aff5fadb0550007971456

@netlify
Copy link

netlify bot commented Feb 4, 2020 •
edited
Loading

Deploy preview for carbon-components-react failed.

Built with commit 9f830b5

https://app.netlify.com/sites/carbon-components-react/deploys/5e3aff5fa49d5800088ef9a3

asudoh
asudoh approved these changes Feb 4, 2020
View reviewed changes
Copy link
Contributor

@asudoh asudoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks @tw15egan!

laurenmrice
laurenmrice approved these changes Feb 5, 2020
View reviewed changes
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me !

@asudoh asudoh merged commit 004c614 into carbon-design-system:master Feb 5, 2020
@asudoh
Copy link
Contributor

asudoh commented Feb 5, 2020

Has @tw15egan's green light on merge - Thanks @tw15egan!

@joshblack joshblack mentioned this pull request Feb 25, 2020
Closed
@tw15egan tw15egan deleted the inline-notification-ie11 branch April 28, 2021 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurenmrice laurenmrice laurenmrice approved these changes

@asudoh asudoh asudoh approved these changes

@abbeyhrt abbeyhrt Awaiting requested review from abbeyhrt

@aledavila aledavila Awaiting requested review from aledavila

Assignees
No one assigned
Labels
status: one more review 👀 status: ready for review 👀
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inline Notification is going outside the borders of it's parent on IE11
3 participants
@tw15egan @asudoh @laurenmrice