-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(accordion): resolve accordion header z-index issue #5276
Conversation
cc @asudoh , ref'd the PR that added that |
Deploy preview for carbon-elements ready! Built with commit 126861a |
Deploy preview for carbon-components-react failed. Built with commit 126861a https://app.netlify.com/sites/carbon-components-react/deploys/5e3dd6556a00ea0008b8f4a0 |
Thanks @tw15egan - As I think you saw, blame history points to #1671 - Would you be able to double-check if every bullets in there has no problem? |
@asudoh checked the list and all still seems good 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 ✅ - Thanks @tw15egan!
I noticed that the issue is also resolved if the z-index is removed, would that be another way to go about this? |
@abbeyhrt I think then the accordion header text is covered on hover |
@tw15egan ah that makes sense! Thanks! |
@abbeyhrt Yeah I think it has to do with the use of |
Closes #5272
Refs #1674
Changes
z-index
value so that radio buttons are not overlayed on tooltip inside the accordion header.Changelog
Changed
z-index
from0
to1
Testing / Reviewing
See https://codesandbox.io/s/zen-hofstadter-km7to for example of the issue. Check a radio button, then hover over the filter icon. Inspect
.bx--accordion__title
and setz-index: 1;
, and see that you can no longer see the filled radio button.