Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(project): update babel for Node v12.17 #6148

Merged

Conversation

joshblack
Copy link
Contributor

We have an issue with Netlify builds failing when using Node v12.17. This issue updates our babel dependencies and resolves @babel/helper-compilation-targets to v7.10. Previously, we were running into conflicting versions of this package (7.8 vs 7.10) that was causing this issue to happen.

Changelog

New

Changed

  • Update babel packages and force resolution for certain packages

Removed

Testing / Reviewing

  • Verify that CI passes

@joshblack joshblack requested a review from a team as a code owner May 27, 2020 15:11
@ghost ghost requested review from asudoh and dakahn May 27, 2020 15:11
@netlify
Copy link

netlify bot commented May 27, 2020

Deploy preview for carbon-elements ready!

Built with commit 0bc74e8

https://deploy-preview-6148--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented May 27, 2020

Deploy preview for carbon-components-react ready!

Built with commit 0bc74e8

https://deploy-preview-6148--carbon-components-react.netlify.app

Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 ✅

@joshblack joshblack requested a review from a team as a code owner May 27, 2020 16:08
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like some snapshots just need to be updated now after the jest update

@joshblack
Copy link
Contributor Author

@emyarod on it! Running now.

@joshblack joshblack merged commit 96ffd02 into carbon-design-system:master May 27, 2020
@joshblack joshblack deleted the chore/update-babel-deps branch May 27, 2020 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants