chore(build): apply babel-plugin-external-helpers to non-demo bundle #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chrisdhanaraj will review this by the end of this sprint. |
joshblack
referenced
this pull request
in joshblack/carbon
May 2, 2019
* fix(overflowmenu): remove handleBlur for now * fix(ie11): temporary remove test
This was referenced Jan 15, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Re-doing #52 - The issue was that unless
rollup-plugin-babelis in usebabel-helpershas to be imported manually (sorry @chrisdhanaraj for the hustle during you are on trip). Only applyingbabel-plugin-external-helpersto our Rollup bundles, therefore.Added
babel-plugin-external-helpersusage to non-demo bundle.Removed
Demo-specific
.babelrcas now.babelrcis the same for regular build vs. demo.Testing / Reviewing
Testing should make sure build/demo is not broken.