-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(button): update Button story and documentation #6565
docs(button): update Button story and documentation #6565
Conversation
Deploy preview for carbon-elements ready! Built with commit d966825 |
Deploy preview for carbon-components-react ready! Built with commit d966825 https://deploy-preview-6565--carbon-components-react.netlify.app |
d72b85f
to
89a2c5e
Compare
@joshblack question about knobs: are we removing them in favor of showing all examples in the docs? Ran into some issues trying to get the Also wondering if we should just focus on the props + usage in the docs, rather than "patterns". In this case, the |
29ea6b8
to
a54060f
Compare
a54060f
to
86720bf
Compare
60cdd5c
to
e898a17
Compare
@andreancardona I just updated this to match the epic / other docs PR's - mainly just removed some extra stories, and put each variation as it's own story. |
Looks good! @tw15egan does percy need to pass? |
@andreancardona approved them, differences were due to changing the stories to show the variants vs the old patterns |
sounds good :) |
6e0edfb
to
409bfc2
Compare
Looks like some conflicts because the new |
e8d3f67
to
f65e6e9
Compare
2d314f6
to
d966825
Compare
@alisonjoseph should be good now 👍 |
Closes #6564
Updates
Button
to new CSF format and adds in prop documentationDone
Button.mdx
and fill out with templateChangelog
New
react/sort-prop-types
as a warning so that ourPropType
definitions are in alphabetical order. THat way the Prop tables will also be in alphabetical order.Docs
tab now includes detailed descriptions of eachprop
as well as examples and code snippetstooltipAlignment
andtooltipPosition
soicon-only-buttons
require two less props to be specified by default.Changed
PropType
definitions alphabeticallyTesting / Reviewing
Check updated docs for grammar usage and that the examples look correct
Questions for reviewers:
set of buttons
story is still up-to-date?Issues for V11
small
instead ofsize