-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): update DatePicker docs #6689
chore(docs): update DatePicker docs #6689
Conversation
Deploy preview for carbon-elements ready! Built with commit 9b28f7a |
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 9b28f7a https://deploy-preview-6689--carbon-components-react.netlify.app |
46de7ce
to
81a4c28
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff! 🏄
81a4c28
to
27754fd
Compare
27754fd
to
9ea683c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, just wondering are we going to have content reviews like when we were rewriting the docs for the website or has it already been approved?
Could be tedious to get content review on each dev docs PR, might be best to have Content do a pass over all the docs once they are up and make changes from there. |
Closes #6688
Updates
DatePicker
to new CSF format and adds in prop documentationDone
DatePicker.mdx
and fill out with templateChangelog
New
Questions for v11
short
prop does not seem to be needed anymore.Testing / Reviewing
Check updated docs for grammar usage and that the examples look correct