fix(Tabs): diff tablist properties on component update #6843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit be68326 |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit be68326 https://deploy-preview-6843--carbon-components-react.netlify.app |
joshblack
approved these changes
Sep 15, 2020
andreancardona
approved these changes
Sep 15, 2020
36 tasks
emyarod
added a commit
to emyarod/carbon
that referenced
this pull request
Sep 18, 2020
…ystem#6843)" This reverts commit 87d02b7.
50 tasks
emyarod
added a commit
to emyarod/carbon
that referenced
this pull request
Sep 28, 2020
…ystem#6843)" This reverts commit 87d02b7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6838
This PR adds a comparison check for the tablist
clientWidth,scrollLeft, andscrollWidthvalues on component update so that dynamic tab list updates will not require interaction to update the overflow button visibilityChangelog
New
Testing / Reviewing
Refer to the example in the ticket for an example to test with. When the tablist is dynamically modified, the overflow button visibility should reflect the current tablist width