fix: update placeholder styles to be consistent in all browsers #6914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emyarod
requested review from
laurenmrice,
aledavila and
dakahn
and removed request for
a team
|
Deploy preview for carbon-elements ready! Built with commit da7866d |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit da7866d https://deploy-preview-6914--carbon-components-react.netlify.app |
laurenmrice
approved these changes
Sep 25, 2020
joshblack
approved these changes
Sep 28, 2020
|
bump @aledavila @dakahn when you all have a sec to review today 👀 |
aledavila
approved these changes
Sep 28, 2020
50 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6908
Closes #6144
Related #4799
This PR updates the
placeholder-colorsmixin and imports it where needed so that placeholder styles are consistent across all browsersChangelog
Changed
placeholder-colorsmixin definitionplaceholder-colorsin date picker, time picker, and search stylesTesting / Reviewing
Confirm that placeholder styles are consistent in all browsers for all relevant components