Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TreeNode): set aria-current on current active node #6937

Merged

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Sep 29, 2020

Refs #6792

This PR couples aria-current="true" to the active tree node as an accessibility enhancement to the experimental treeview. The remaining points in the issue will be addressed at a later time when we are ready to reprioritize this effort but the current PR will serve as the demo for the upcoming ARIA deep dive on trees (part 3)

Changelog

New

  • aria-current attribute for the active tree node

Testing / Reviewing

Confirm that the active tree node receives aria-current="true" and all other nodes do not have this attribute

@netlify
Copy link

netlify bot commented Sep 29, 2020

Deploy preview for carbon-elements ready!

Built with commit e531a58

https://deploy-preview-6937--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Sep 30, 2020

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit e531a58

https://deploy-preview-6937--carbon-components-react.netlify.app

@carmacleod
Copy link
Contributor

carmacleod commented Oct 1, 2020

@emyarod Please see: emyarod#1

@kodiakhq kodiakhq bot merged commit 282bdd4 into carbon-design-system:master Oct 2, 2020
@emyarod emyarod deleted the 6792-treeview-a11y-fixes branch October 2, 2020 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants