-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(TreeNode): set aria-current on current active node #6937
Merged
kodiakhq
merged 6 commits into
carbon-design-system:master
from
emyarod:6792-treeview-a11y-fixes
Oct 2, 2020
Merged
feat(TreeNode): set aria-current on current active node #6937
kodiakhq
merged 6 commits into
carbon-design-system:master
from
emyarod:6792-treeview-a11y-fixes
Oct 2, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploy preview for carbon-elements ready! Built with commit e531a58 |
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit e531a58 https://deploy-preview-6937--carbon-components-react.netlify.app |
dakahn
approved these changes
Sep 30, 2020
emyarod
force-pushed
the
6792-treeview-a11y-fixes
branch
from
October 1, 2020 14:05
5f381d1
to
3ba3f83
Compare
50 tasks
tw15egan
approved these changes
Oct 1, 2020
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #6792
This PR couples
aria-current="true"
to the active tree node as an accessibility enhancement to the experimental treeview. The remaining points in the issue will be addressed at a later time when we are ready to reprioritize this effort but the current PR will serve as the demo for the upcoming ARIA deep dive on trees (part 3)Changelog
New
aria-current
attribute for the active tree nodeTesting / Reviewing
Confirm that the active tree node receives
aria-current="true"
and all other nodes do not have this attribute