Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tabs): remove role knob #6981

Merged
merged 2 commits into from
Oct 6, 2020
Merged

fix(tabs): remove role knob #6981

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aaa0e97
fix(tabs): remove role knob
tw15egan Oct 6, 2020
7716d43
Merge branch 'master' into remove-role
kodiakhq[bot] Oct 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/react/src/components/Tabs/Tabs-story.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ const props = {
className: 'some-class',
light: boolean('Light variant (light)', false),
selected: number('The index of the selected tab (selected in <Tabs>)', 1),
role: text('ARIA role (role in <Tabs>)', 'navigation'),
// Disabling action logger for `<Tabs onClick onKeyDown>` for now given it seems to be significantly slowing down Storybook
// onClick: action('onClick'),
// onKeyDown: action('onKeyDown'),
Expand All @@ -53,7 +52,6 @@ const props = {
tab: () => ({
disabled: boolean('Disabled (disabled in <Tab>)', false),
href: text('The href for tab (href in <Tab>)', '#'),
role: text('ARIA role (role in <Tab>)', 'presentation'),
tabIndex: number('Tab index (tabIndex in <Tab>)', 0),
onClick: action('onClick'),
onKeyDown: action('onKeyDown'),
Expand Down