fix(modal): only call toggleClass when needed #7082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit 5cbeec1 |
joshblack
approved these changes
Oct 19, 2020
|
Deploy preview for carbon-components-react ready! Built with commit 5cbeec1 https://deploy-preview-7082--carbon-components-react.netlify.app |
aledavila
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7011
Adds in check to ensure we only call
toggleClasswhen the open state is changedChangelog
New
toggleClasswhen the state has changedTesting / Reviewing
Go to
ComposedModaland try toggling the modal via knobs andxicon and ensure everything still works