Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(multi-select): update filterable multiselect default styles #7108

Merged
merged 1 commit into from
Oct 22, 2020
Merged

fix(multi-select): update filterable multiselect default styles #7108

merged 1 commit into from
Oct 22, 2020

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Oct 21, 2020

Closes #7041

This PR updates the filterable multiselect styles to match the updated component spec

Testing / Reviewing

Confirm the filterable multiselect variants are visually correct

@emyarod emyarod requested a review from a team as a code owner October 21, 2020 17:13
@netlify
Copy link

netlify bot commented Oct 21, 2020 •
edited
Loading

Deploy preview for carbon-elements ready!

Built with commit 6e00fc9

https://deploy-preview-7108--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Oct 21, 2020 •
edited
Loading

Deploy preview for carbon-components-react ready!

Built with commit 6e00fc9

https://deploy-preview-7108--carbon-components-react.netlify.app

@laurenmrice
Copy link
Member

laurenmrice commented Oct 21, 2020 •
edited
Loading

This change needs to only happen for the inline variant of the filterable multiselect. The default filterable multiselect needs to keep its field-01 background (and field-02 background for the light prop).

We just need to change the inline version to not have a field background color. When the menu is open, only the options should still get the field-01 (and field-02 for the light prop)

andreancardona
andreancardona approved these changes Oct 21, 2020
View reviewed changes
Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emyarod looks good to me! 🎉

tw15egan
tw15egan requested changes Oct 21, 2020
View reviewed changes
Copy link
Member

@tw15egan tw15egan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should only apply to inline variant

@emyarod emyarod force-pushed the 7041-filterable-multiselect-styles branch from 263f9b3 to 6e00fc9 Compare October 22, 2020 15:06
@emyarod emyarod requested a review from tw15egan October 22, 2020 15:06
laurenmrice
laurenmrice approved these changes Oct 22, 2020
View reviewed changes
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! thanks ! 🙌🏻

@kodiakhq kodiakhq bot merged commit b0839d1 into carbon-design-system:master Oct 22, 2020
@emyarod emyarod deleted the 7041-filterable-multiselect-styles branch October 22, 2020 17:05
@emyarod emyarod mentioned this pull request Oct 30, 2020
Closed
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@tw15egan tw15egan tw15egan approved these changes

@andreancardona andreancardona andreancardona approved these changes

@laurenmrice laurenmrice laurenmrice approved these changes

Assignees
No one assigned
Labels
status: ready for review 👀 status: ready to merge 🎉 status: visual review 🔍
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue: Filterable Multiselect inline property not displaying correctly
5 participants
@emyarod @laurenmrice @joshblack @tw15egan @andreancardona