-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(react): update tests from DAP to AC #7506
refactor(react): update tests from DAP to AC #7506
Conversation
FYI @dakahn |
✔️ Deploy preview for carbon-elements ready! 🔨 Explore the source changes: 0a468f6 🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-elements/deploys/5ffdfe6e666a990008b65b2c 😎 Browse the preview: https://deploy-preview-7506--carbon-elements.netlify.app |
✔️ Deploy preview for carbon-components-react ready! 🔨 Explore the source changes: 0a468f6 🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-components-react/deploys/5ffdfe6e3709d00007648bf6 😎 Browse the preview: https://deploy-preview-7506--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
bump @andreancardona let me know if you have any questions! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@josh looks good!
This PR is some clean-up for some of our old AAT files as they relate to DAP. It removes DAP files, matchers, and updates test files to use the new AC matcher.
Changelog
New
Changed
toHaveNoDAPViolations
toHaveNoACViolations
Removed
aat
folder was removedtoHaveNoDAPViolations
was removed