fix(Tabs): apply scrollIntoView prop on mount
#7543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy preview for carbon-elements ready! 🔨 Explore the source changes: 5d1640e 🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-elements/deploys/60072f7dbd82600007f91ca4 😎 Browse the preview: https://deploy-preview-7543--carbon-elements.netlify.app |
|
✔️ Deploy preview for carbon-components-react ready! 🔨 Explore the source changes: 5d1640e 🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-components-react/deploys/60072f7d27a0790007eb252c 😎 Browse the preview: https://deploy-preview-7543--carbon-components-react.netlify.app |
emyarod
force-pushed
the
apply-scrollIntoView-prop-on-mount
branch
from
1bfc471
to
985d66b
Compare
joshblack
approved these changes
Jan 13, 2021
andreancardona
approved these changes
Jan 19, 2021
andreancardona
added
status: ready to merge 🎉
and removed
status: ready for review 👀
labels
46 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow up to #7410 which added a
scrollIntoViewprop to allow more granular control over autoscroll behavior. The prop value should now be respected on component mount as well as updatesTesting / Reviewing
Confirm that autoscroll is dictated by the prop value on component mount and on component updates