Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: move lint and format to GitHub Actions #7547

Merged
merged 5 commits into from
Jan 15, 2021
Merged

ci: move lint and format to GitHub Actions #7547

merged 5 commits into from
Jan 15, 2021

Conversation

joshblack
Copy link
Contributor

Move lint and format tasks from CircleCI to GitHub Actions. This should help speed up CI builds by using parallelism across workers.

Changelog

New

Changed

  • Update CLI to only run tests
  • Update CI workflow to include format and lint

Removed

@netlify
Copy link

netlify bot commented Jan 12, 2021

✔️ Deploy preview for carbon-elements ready!

🔨 Explore the source changes: 55e0ec7

🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-elements/deploys/5ffe309bcf0c030008671309

😎 Browse the preview: https://deploy-preview-7547--carbon-elements.netlify.app

@joshblack joshblack marked this pull request as ready for review January 12, 2021 23:47
@joshblack joshblack requested a review from a team as a code owner January 12, 2021 23:47
@netlify
Copy link

netlify bot commented Jan 12, 2021

✔️ Deploy preview for carbon-components-react ready!

🔨 Explore the source changes: 55e0ec7

🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-components-react/deploys/5ffe309bee019f000776bbb9

😎 Browse the preview: https://deploy-preview-7547--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Jan 12, 2021 •
edited
Loading

✔️ Deploy preview for carbon-elements ready!

🔨 Explore the source changes: c5ae530

🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-elements/deploys/6001bed0e47d6e0007b91f8c

😎 Browse the preview: https://deploy-preview-7547--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jan 13, 2021 •
edited
Loading

✔️ Deploy preview for carbon-components-react ready!

🔨 Explore the source changes: c5ae530

🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-components-react/deploys/6001bed0a41b070008553e0c

😎 Browse the preview: https://deploy-preview-7547--carbon-components-react.netlify.app

emyarod
emyarod approved these changes Jan 13, 2021
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@joshblack
Copy link
Contributor Author

Let me know if you have any questions @andreancardona !

andreancardona
andreancardona approved these changes Jan 15, 2021
View reviewed changes
Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshblack look good! 🍕

@joshblack joshblack merged commit 477f97a into master Jan 15, 2021
@joshblack joshblack deleted the ci/move-lint-to-actions branch January 15, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreancardona andreancardona andreancardona approved these changes

@emyarod emyarod emyarod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshblack @emyarod @andreancardona