Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(components,react): add telemetry package #7610

Merged
merged 1 commit into from
Jan 21, 2021
Merged

feat(components,react): add telemetry package #7610

merged 1 commit into from
Jan 21, 2021

Conversation

joshblack
Copy link
Contributor

Adds in the telemetry package to carbon-components and carbon-components-react

Changelog

New

Changed

  • Update packages/components and packages/react to include @carbon/telemetry in their postinstall step

Removed

Testing / Reviewing

  • Verify that the build succeeds on CI

@joshblack joshblack requested a review from a team as a code owner January 20, 2021 17:43
@netlify
Copy link

netlify bot commented Jan 20, 2021

✔️ Deploy preview for carbon-elements ready!

🔨 Explore the source changes: e2cdf26

🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-elements/deploys/60086bb142bfbb0008778e90

😎 Browse the preview: https://deploy-preview-7610--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Jan 20, 2021

✔️ Deploy preview for carbon-components-react ready!

🔨 Explore the source changes: e2cdf26

🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-components-react/deploys/60086bb1741f640007289ee1

😎 Browse the preview: https://deploy-preview-7610--carbon-components-react.netlify.app

emyarod
emyarod approved these changes Jan 21, 2021
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

andreancardona
andreancardona approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshblack looks good! ☕

@joshblack joshblack merged commit d5aeb25 into carbon-design-system:master Jan 21, 2021
@joshblack joshblack deleted the feat/add-telemetry-to-packages-v2 branch January 21, 2021 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreancardona andreancardona andreancardona approved these changes

@emyarod emyarod emyarod approved these changes

@tw15egan tw15egan Awaiting requested review from tw15egan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joshblack @emyarod @andreancardona