Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(treeview): update text and color tokens to match spec #8075

Merged

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Mar 11, 2021

Closes #8000

This PR updates the text and color tokens for the treeview hover and enabled state

Changelog

New

  • story specific tree width rule

Changed

  • hover and enabled state text and color tokens

@netlify
Copy link

netlify bot commented Mar 11, 2021

Deploy preview for carbon-elements ready!

Built with commit 47e63db

https://deploy-preview-8075--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Mar 11, 2021

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit 47e63db

https://deploy-preview-8075--carbon-components-react.netlify.app

Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hover and Selected states: Icons need to be icon-01 to match the text color.
hover

Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When a top level parent is selected and open, the nested items that have a caret icon are currently getting an icon-01 color. The unselected items with caret icons should be icon-02 unless they are selected or hovered on.
Screen Shot 2021-03-15 at 9 48 59 AM

Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok last thing, the disabled nodes just need to get a disabled cursor applied on hover. Everything else looks great !

@emyarod
Copy link
Member Author

emyarod commented Mar 16, 2021

I believe the cursor style for disabled items was intentional to match behavior in native context menus, but since we now have a context menu component and use the disabled cursor there I can make that change here as well

@emyarod emyarod force-pushed the 8000-treeview-token-updates branch from 8aa2963 to d183e60 Compare March 16, 2021 16:00
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🎉

@kodiakhq kodiakhq bot merged commit 5efe028 into carbon-design-system:main Mar 22, 2021
@emyarod emyarod deleted the 8000-treeview-token-updates branch March 22, 2021 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tree view] code bugs
4 participants