-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(treeview): update text and color tokens to match spec #8075
fix(treeview): update text and color tokens to match spec #8075
Conversation
Deploy preview for carbon-elements ready! Built with commit 47e63db |
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 47e63db https://deploy-preview-8075--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1d32071
to
8626f4f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok last thing, the disabled nodes just need to get a disabled cursor applied on hover. Everything else looks great !
I believe the cursor style for disabled items was intentional to match behavior in native context menus, but since we now have a context menu component and use the disabled cursor there I can make that change here as well |
8aa2963
to
d183e60
Compare
802107d
to
5ceb3ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 🎉
Closes #8000
This PR updates the text and color tokens for the treeview hover and enabled state
Changelog
New
Changed