-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(structured-list): top align header text #8166
fix(structured-list): top align header text #8166
Conversation
Deploy preview for carbon-elements ready! Built with commit c4c64b9 |
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit c4c64b9 https://deploy-preview-8166--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
the line heights are set by our type mixins so we will need to see if they need to be updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 ✅
DCO Assistant Lite bot: Thanks for your submission! We ask that you all sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text: I have read the DCO document and I hereby sign the DCO. 0 out of 2 committers have signed the DCO. |
Closes #8157
related #721
related #753
This PR top aligns headers so that they stay aligned with non-header text in structured lists
Testing / Reviewing
Apply the header class to a list row cell and check its vertical alignment