fix(date-picker): remove redundant date picker border radius #8259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DCO Assistant Lite bot All contributors have signed the DCO. |
|
Deploy preview for carbon-elements ready! Built with commit 8ee063c |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit 8ee063c https://deploy-preview-8259--carbon-components-react.netlify.app |
andreancardona
approved these changes
Mar 31, 2021
tw15egan
approved these changes
Apr 1, 2021
|
@emyarod I think enabling the linting would be beneficial, but doesn't need to be bundled in here if you don't want to comb through the warnings |
joshblack
approved these changes
Apr 1, 2021
jnm2377
requested review from
a team and
johnbister
and removed request for
a team
johnbister
approved these changes
Apr 3, 2021
|
I have read the DCO document and I hereby sign the DCO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #8190
Related #8198
This PR removes a redundant border-radius rule on the flatpickr styles
the flatpickr styles are not being linted, should I enable the linter?
Testing / Reviewing
The date picker calendar should not have a border radius value