fix(SelectableTile): sync selected prop and state #8279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DCO Assistant Lite bot All contributors have signed the DCO. |
86 tasks
|
Deploy preview for carbon-elements failed. Built with commit df08693 https://app.netlify.com/sites/carbon-elements/deploys/607482304635de0aeff577aa |
|
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit df08693 https://deploy-preview-8279--carbon-components-react.netlify.app |
joshblack
reviewed
Apr 2, 2021
emyarod
force-pushed
the
7759-selectabletile-controlled-mode
branch
from
944e37e
to
11bd374
Compare
tay1orjones
approved these changes
Apr 6, 2021
joshblack
approved these changes
Apr 8, 2021
jnm2377
approved these changes
Apr 11, 2021
emyarod
force-pushed
the
7759-selectabletile-controlled-mode
branch
from
727b379
to
479fb55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7759
This PR keeps the selectable tile's selected state in sync to prevent unexpected selection behavior
Changelog
Changed
handleClickandhandleKeyDownprops in favor of standardonClickandonKeyDownpropsselectedprop when providedTesting / Reviewing
ensure the existing tile use cases work as expected together with the added temp example