feat(Pagination): enable seperate disable controls for page size, page #8345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tw15egan
requested review from
a team and
aagonzales
and removed request for
a team
|
Deploy preview for carbon-elements ready! Built with commit a6f56f3 |
|
Deploy preview for carbon-components-react ready! Built with commit a6f56f3 https://deploy-preview-8345--carbon-components-react.netlify.app |
tw15egan
force-pushed
the
pagination-disable-change
branch
from
f9fff94
to
862142c
Compare
aagonzales
approved these changes
Apr 9, 2021
|
@tw15egan is this ready to be merged? |
|
@andreancardona can you review this when you get a chance? |
joshblack
approved these changes
Apr 15, 2021
tw15egan
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
tw15egan
force-pushed
the
pagination-disable-change
branch
from
fc99769
to
8614495
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8311
Refs #6070
Refs #6055
This un-deprecates the
pageInputDisabledprop, and adds in thepageSizeInputDisabledprop. Now,pageInputDisabledwill only disable the right-sidedpageSelectinput.pageSizeInputDisabledwill disable the leftpageSizeSelectelement.disablewill still disable all select elementsChangelog
New
pageSizeInputDisabledadded to control the left page sizeSelectelementChanged
pageInputDisabledwill only target the right pageSelectelementRemoved
pageInputDisabledso users have more control over which parts of thePaginationcomponent they want disabled.Testing / Reviewing
Use the knobs in the storybook to disable each select individually, and ensure the
disableprop still works as expected and disabled all elementsPossibly breaking: Anyone that was using
pageInputDisabledinstead ofdisableto disable all elements will now only have the right pageSelectdisabled.