feat(tokens): update color tokens pt3 #8376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tw15egan
changed the title
|
Deploy preview for carbon-elements failed. Built with commit 8d3ac25 https://app.netlify.com/sites/carbon-elements/deploys/6082be1317543c0008386b4a |
|
Deploy preview for carbon-components-react failed. Built without sensitive environment variables with commit 8d3ac25 https://app.netlify.com/sites/carbon-components-react/deploys/6082be1310aec100083d09c7 |
tw15egan
commented
Apr 13, 2021
packages/components/src/components/data-table/_data-table-core.scss
Outdated
Show resolved
Hide resolved
aagonzales
requested changes
Apr 14, 2021
packages/components/src/components/data-table/_data-table-core.scss
Outdated
Show resolved
Hide resolved
packages/components/src/components/data-table/_data-table-core.scss
Outdated
Show resolved
Hide resolved
tw15egan
force-pushed
the
token-update-pt3
branch
from
69a5f9b
to
04a2c8f
Compare
|
@aagonzales just pushed up some changes 👍🏻 |
aagonzales
approved these changes
Apr 15, 2021
emyarod
approved these changes
Apr 16, 2021
jnm2377
approved these changes
Apr 23, 2021
jnm2377
added
status: ready to merge 🎉
and removed
status: ready for review 👀
status: visual review 🔍
labels
nertzy
reviewed
May 3, 2021
joshblack
added a commit
to joshblack/carbon
that referenced
this pull request
Jun 29, 2021
)" This reverts commit 3804612.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8303
Components to be updated:
We will also need to update all global scss files to reference new color tokens
globals/scssChangelog
Changed
Removed
Testing / Reviewing
Go over the list above and ensure all components look correct