-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(carbon-react): add README and initial sass config docs #8586
docs(carbon-react): add README and initial sass config docs #8586
Conversation
Deploy preview for carbon-elements ready! Built with commit 15280a5 |
Deploy preview for carbon-components-react ready! Built with commit 15280a5 https://deploy-preview-8586--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple things that stuck out, but overall looks great to me!
Co-authored-by: Taylor Jones <tay1orjones@users.noreply.github.com>
Co-authored-by: Taylor Jones <tay1orjones@users.noreply.github.com>
Co-authored-by: Taylor Jones <tay1orjones@users.noreply.github.com>
…arbon into docs/add-carbon-react-readme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just a few comments
Closes #8558
This PR adds in our initial README and sass doc for our beta release next week. The goal with this work is to provide the minimal documentation needed for teams to get started with:
It's also a chance for our team to see the new package architecture and see how it fits in with our plans moving forward 👀
Changelog
New
@carbon/react
@carbon/react
Changed
@carbon/react
Removed
Testing / Reviewing