fix(type): update tokens to include new expressive tokens #8661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for carbon-elements ready! Built with commit 4077217 |
|
Deploy preview for carbon-components-react failed. Built without sensitive environment variables with commit 4077217 https://app.netlify.com/sites/carbon-components-react/deploys/609d370d9be80e00079399e4 |
emyarod
approved these changes
May 12, 2021
joshblack
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates our sass files in
@carbon/typeto include the new expressive tokens in our tokens map. This map is used to generate the type classes that are used in the elements preview.Changelog
New
Changed
styles.scssto include the new expressive tokens in our tokens mapRemoved
Testing / Reviewing
label-02,caption-02, andhelper-text-02all use 14px and have the corresponding type token styles applied 👍