feat(datepicker): add onOpen callback #8705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy Preview for carbon-elements ready! Built with commit a4ce010 |
|
Deploy Preview for carbon-components-react ready! Built without sensitive environment variables with commit a4ce010 https://deploy-preview-8705--carbon-components-react.netlify.app |
andreancardona
approved these changes
May 18, 2021
|
@tay1orjones any clue what's going on with the CI checks? |
|
@andreancardona There's an ongoing incident with GitHub actions. It sounds like it should be coming back up soon |
87 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8698
This adds an
onOpencallback prop that exposes flatpickr'sonOpento consumers while still calling the internalonHook.Changelog
New
Changed
Testing / Reviewing
Datepicker should function the exact same as it did before with no regressions. The playground story should show action functions being called on open and close of the datepicker passing along the expected args.