-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(styles): add accordion styles and tests #8735
feat(styles): add accordion styles and tests #8735
Conversation
…at/refactor-component-styles
cc @tw15egan would love your thoughts here 👀 |
Deploy Preview for carbon-elements ready! Built with commit 9b2c079 |
Deploy Preview for carbon-components-react ready! Built without sensitive environment variables with commit 9b2c079 https://deploy-preview-8735--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, and I believe a couple of snapshots will need to be updated
Part of #8555
This converts our accordion styles to Sass modules and also updates some of the existing packages to make it work. There were some challenges that came up where it would be great to get feedback on:
_theme.scss
module export all theme members, or just colors?@use 'module-name'
versususe 'module-name' as *
to bring members in to scopeChangelog
New
_tokens.scss
file to themes to map variables like$interactive-01
over to their CSS Custom Property variantChanged
@include button-reset.button-reset()
becomes@include button-reset.reset()
Removed
Testing / Reviewing