-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sketch): hide shared color styles sync command #8770
fix(sketch): hide shared color styles sync command #8770
Conversation
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 6908582 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60e47920ab6d4400079159a7 😎 Browse the preview: https://deploy-preview-8770--carbon-elements.netlify.app |
d1214d5
to
ab809e4
Compare
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: d1214d5 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60ae96224c92460007a4b4a9 😎 Browse the preview: https://deploy-preview-8770--carbon-components-react.netlify.app |
ab809e4
to
535e97c
Compare
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: ab809e4 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60ae9af3d41d9b000753d937 😎 Browse the preview: https://deploy-preview-8770--carbon-components-react.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 6908582 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60e479206935330007879491 😎 Browse the preview: https://deploy-preview-8770--carbon-components-react.netlify.app |
535e97c
to
71608fe
Compare
71608fe
to
0fda8b2
Compare
❌ Deploy Preview for carbon-react-next failed. 🔨 Explore the source changes: 6908582 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/60f597cc72767e2c40034949 |
Closes #8766
This PR introduces a new
syncColors
function to handle syncing of shared layer color styles and color variables. The sync shared styles command for colors is also hidden from the plugin menu now and kept as an internal shared function onlyTesting / Reviewing
Confirm that color variables still sync as expected, and there are no regressions with commands that rely on the color shared styles commands e.g. icons sync
carbon-elements.sketchplugin.zip