fix(button): fix icon color on disabled icon only ghost buttons #8810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: c842e8f 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60b691e5ae354f0007db2872 😎 Browse the preview: https://deploy-preview-8810--carbon-elements.netlify.app |
|
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: c842e8f 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60b691e5fb486e00089fef50 😎 Browse the preview: https://deploy-preview-8810--carbon-components-react.netlify.app/iframe |
joshblack
approved these changes
Jun 1, 2021
joshblack
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
emyarod
pushed a commit
to emyarod/carbon
that referenced
this pull request
Jun 10, 2021
…on-design-system#8810) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the recent selector change in #8585 regarding the icon color on buttons, the specificity increased and caused disabled icon-only ghost buttons to use
$icon-primaryinstead of$icon-on-color-disabled. This PR adds the same selector addition to the disabled icon-only ghost buttons.Before
After
Changelog
Changed
Testing / Reviewing
$icon-on-color-disabled