fix(Tooltip): avoid stealing focus when dismissing with mouseclick #8820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: e425fcd 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/60bf94a9f7eb020007c00291 😎 Browse the preview: https://deploy-preview-8820--carbon-elements.netlify.app |
|
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: e425fcd 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/60bf94a938fd2b000812671f 😎 Browse the preview: https://deploy-preview-8820--carbon-components-react.netlify.app/iframe |
emyarod
force-pushed
the
8180-tooltip-mouseclick-dismissal-focus-management
branch
from
07cd72b
to
7cdebb0
Compare
tay1orjones
approved these changes
Jun 3, 2021
|
bump @dakahn when you have a chance! |
dakahn
approved these changes
Jun 8, 2021
emyarod
force-pushed
the
8180-tooltip-mouseclick-dismissal-focus-management
branch
from
7cdebb0
to
e425fcd
Compare
emyarod
added
status: ready to merge 🎉
and removed
status: one more review 👀
status: ready for review 👀
labels
85 tasks
emyarod
added a commit
to emyarod/carbon
that referenced
this pull request
Jun 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8180
This PR updates the interactive tooltip's user initiated open/close logic to avoid stealing focus after dismissal via mouse click
Testing / Reviewing
Confirm that the interactive tooltip trigger does not steal focus only after the tooltip is dismissed by user click