-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Combobox): add event propagation to mouse down #9402
fix(Combobox): add event propagation to mouse down #9402
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 405c5d2 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6130c0c72a0aec0007226e2d 😎 Browse the preview: https://deploy-preview-9402--carbon-react-next.netlify.app/ |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 405c5d2 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6130c0c7e63d5e00086e61c5 😎 Browse the preview: https://deploy-preview-9402--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 405c5d2 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6130c0c70b603900075f6b3c 😎 Browse the preview: https://deploy-preview-9402--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working as expected 👍🏻 ✅
…om/dakahn/carbon into 9073-add-combobox-eventpropagation
I debugged this at length with @sstrubberg today, and it seems just scoping the only.one.open.at.a.time.movI added a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-reviewed and removed the test story, LGTM 👍🏻
Closes #9073
event.stopPropagation()
from theonMouseUp
event on the toggle button's props.onMouseUp
on the toggle button now moves active focus to the text inputTesting / Reviewing
../ComboBox-story.js
and duplicate the<ComboBox>
seen on line 65 like soNotes
@joshblack pretty sure stopping event propagation was critical for some reason we're missing here -- do you remember why?