Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Search): match close button border color - light variant #9489

Merged
merged 2 commits into from
Aug 27, 2021

Conversation

tw15egan
Copy link
Member

Closes #9488

Matches the ::before element to the light variant background

Changelog

New

  • Added correct background to ::before element when using the light variant

Testing / Reviewing

Take a look at the light variant and ensure there is no visible border when the close button is present

@tw15egan tw15egan requested a review from a team as a code owner August 17, 2021 13:33
@netlify
Copy link

netlify bot commented Aug 17, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: e211e29

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6128c21e041f51000871b95e

😎 Browse the preview: https://deploy-preview-9489--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Aug 17, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: e211e29

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6128c21e5d284a00071bfcae

😎 Browse the preview: https://deploy-preview-9489--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Aug 17, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: e211e29

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6128c21ea463b00008fa73e5

😎 Browse the preview: https://deploy-preview-9489--carbon-components-react.netlify.app

@kodiakhq kodiakhq bot merged commit 7a1779b into carbon-design-system:main Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Light Search variant has visible left border on close button
3 participants