Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FormGroup): only place className on outer wrapper #9526

Merged
merged 2 commits into from
Sep 10, 2021

Conversation

tw15egan
Copy link
Collaborator

Closes #4572

This ensures the className prop is only placed on the outer wrapper, and not duplicated. I've placed this behind a feature flag, but we may just want to go ahead and make this change as it would be difficult to style them independently as-is

Changelog

New

  • Test story in FormGroup

Changed

  • className prop is only placed on the outer wrapping fieldset element

Testing / Reviewing

Go to the test story and ensure the custom class is only placed on the outer wrapper

@netlify
Copy link

netlify bot commented Aug 24, 2021

❌ Deploy Preview for carbon-react-next failed.

🔨 Explore the source changes: ad08cae

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/613b3648648e14000891e768

@netlify
Copy link

netlify bot commented Aug 24, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: ad08cae

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/613b3648256483000870cee7

😎 Browse the preview: https://deploy-preview-9526--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Aug 24, 2021

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: ad08cae

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/613b36489b94e60007be31d0

😎 Browse the preview: https://deploy-preview-9526--carbon-components-react.netlify.app

@tw15egan
Copy link
Collaborator Author

bump @joshblack when you have a chance 👍🏻

Copy link
Contributor

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems great! Quick question on the test stories, do we want those showing up in the production storybook or are you removing/disabling them before merge? 👀

@joshblack
Copy link
Contributor

So sorry about the delay @tw15egan! Totally missed this 🤦

@tw15egan
Copy link
Collaborator Author

@joshblack will get rid of them before merging 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FormGroup]: Custom className prop gets applied to both the label and the fieldset elements
3 participants