Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Search): pass className to custom icons #9554

Merged
merged 3 commits into from
Sep 3, 2021
Merged

fix(Search): pass className to custom icons #9554

merged 3 commits into from
Sep 3, 2021

Conversation

tw15egan
Copy link
Collaborator

Closes #9551

Now passes in the bx--search-magnifier-icon class to any custom icon passed in to replace the magnifier icon

Changelog

New

  • Test story to display the fix

Changed

  • Adds in the bx--search-magnifier-icon to any custom icon passed in to Search

Testing / Reviewing

Ensure a custom icon renders like the magnifier icon

@tw15egan tw15egan requested a review from a team as a code owner August 27, 2021 12:57
@netlify
Copy link

netlify bot commented Aug 27, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: cdb0c1f

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6131e4e41ee92400071bd03b

😎 Browse the preview: https://deploy-preview-9554--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Aug 27, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: cdb0c1f

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6131e4e4e5971f0007a25422

😎 Browse the preview: https://deploy-preview-9554--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Aug 27, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: cdb0c1f

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6131e4e4a0bf5f00075b2e22

😎 Browse the preview: https://deploy-preview-9554--carbon-components-react.netlify.app

@sstrubberg
Copy link
Member

@tw15egan do we need to remove that extra story before merging or do you want to keep that?

@tw15egan
Copy link
Collaborator Author

I can remove it before merging once @jnm2377 reviews 👍🏻

jnm2377
jnm2377 approved these changes Sep 2, 2021
View reviewed changes
Copy link
Contributor

@jnm2377 jnm2377 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!! 🔥

@kodiakhq kodiakhq bot merged commit 47cd6ea into carbon-design-system:main Sep 3, 2021
This was referenced Sep 15, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnm2377 jnm2377 jnm2377 approved these changes

@sstrubberg sstrubberg sstrubberg approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Search] custom icon does not have '.bx--search-magnifier-icon css class'
3 participants
@tw15egan @sstrubberg @jnm2377