Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Tooltip): only callback parent onChange if it exists #9558

Merged
merged 2 commits into from
Sep 1, 2021

Conversation

tw15egan
Copy link
Member

Closes #9555

Only provides a callback to parent onChange if a onChange is provided

Changelog

Changed

  • Only fires the parent onChange when isControlled if one is provided

Testing / Reviewing

Go to the uncontrolled tooltip story and ensure no console warning is emitted

@tw15egan tw15egan requested a review from a team as a code owner August 30, 2021 11:24
@netlify
Copy link

netlify bot commented Aug 30, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 3c5da93

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/612fdedd5e60cc00087ebf7b

😎 Browse the preview: https://deploy-preview-9558--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Aug 30, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 3c5da93

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/612fdedd0f31740008ba3e2e

😎 Browse the preview: https://deploy-preview-9558--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Aug 30, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 3c5da93

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/612fdedd8632280007bd90f0

😎 Browse the preview: https://deploy-preview-9558--carbon-components-react.netlify.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Console warning in the uncontrolled state of the Tooltip component
3 participants